This repository has been archived by the owner on Jun 13, 2024. It is now read-only.
Add cache_file parameter for DynamicClient #405
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alina Buzachis <[email protected]>
Akasurde
reviewed
Mar 31, 2021
plugins/module_utils/common.py
Outdated
| try: | ||
| client = DynamicClient(kubernetes.client.ApiClient(configuration)) | ||
| client = DynamicClient(kubernetes.client.ApiClient(configuration), cache_file) |
There was a problem hiding this comment.
Suggested change
| client = DynamicClient(kubernetes.client.ApiClient(configuration), cache_file) | |
| client = DynamicClient(kubeclient, cache_file) |
Could you please add test case and changelog for this change? Thanks
There was a problem hiding this comment.
Yes, sure. I also applied this change. Thanks.
alinabuzachis
force-pushed
the
cache_file
branch
2 times, most recently
from
aae4828 to
1d3f2a9
Compare
|
@alinabuzachis I am getting this - Ok, let me try. |
* Address reviewer's comments * Add six in requirements.txt Signed-off-by: Alina Buzachis <[email protected]>
alinabuzachis
force-pushed
the
cache_file
branch
from
1d3f2a9 to
b857e69
Compare
Codecov Report
@@ Coverage Diff @@
## main #405 +/- ##
=======================================
Coverage 23.17% 23.17%
=======================================
Files 1 1
Lines 151 151
Branches 24 24
=======================================
Hits 35 35
Misses 111 111
Partials 5 5 Continue to review full report at Codecov.
|
alinabuzachis
force-pushed
the
cache_file
branch
3 times, most recently
from
c6ce6cb to
fe7f204
Compare
Signed-off-by: Alina Buzachis <[email protected]>
alinabuzachis
force-pushed
the
cache_file
branch
from
fe7f204 to
fb44b2b
Compare
Signed-off-by: Alina Buzachis <[email protected]>
|
Closing as this has been reopened in ansible-collections/kubernetes.core#46. |
|
This repository does not accept pull requests, see the README for details. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY